Dolphin-plugins - Perforce support

[Martin Andersen]

On Sun, Nov 4, 2012 at 11:19 AM, Frank Reininghaus <frank78ac at googlemail.com
> wrote:

> > I have uploaded the code to github:
> > https://github.com/martin9000andersen/dolphin-perforce-plugin
>
>
> thanks! Code looks OK from my point of view, but I'm not a version
> control expert, so I would appreciate any feedback from others. I only
> found some trailing whitespace, commented-out code that should be
> removed, and string constructions that could be made more efficient
> [1].
>

Thanks for the feedback. I will have a look at it later today.


> Would you be willing to maintain the plugin in the future? We would
> then add a new component at bugs.kde.org and assign it to you.
>

Yes, I will do my best to maintain the plugin.

>
> Another question is if it's still possible to merge this plugin for
> KDE 4.10. We're officially in soft feature freeze, and the hard
> feature freeze starts on November 8. We might have to ask the Release
> Team for an exception (release-team at kde.org). If you want to do that,
> you can tell them that I support your request.
>

 Ok. I will send them a mail in a few hours.

> [1]
> http://doc-snapshot.qt-project.org/4.8/qstring.html#more-efficient-string-construction
>

BR,
Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121104/d5c75d98/attachment.htm>