Review Request: show video previews according to file content instead of mimetype string

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104988/#review13988
-----------------------------------------------------------


Thanks a lot for the patch, looks good! I've just tested it: It works fine and I've pushed it to master. I initially was a little bit confused about the semantics of the hasVideoChanged()-signal and wanted to adjust the name of the signal. But I've seen you've taken the same name as Phonon uses in the MediaObject and probably we should stay consistent here. So I've only added a small comment to the signal...

- Peter Penz


On May 19, 2012, 6:54 a.m., Hui Ni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104988/
> -----------------------------------------------------------
> 
> (Updated May 19, 2012, 6:54 a.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string.
> There are container formats which can be either audios or videos.
> Besides, the rmvb video files have mimetype of "application/vnd.rn-realmedia", and these files can be recognized as videos correctly now.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.h 1d964f5 
>   dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 
>   dolphin/src/panels/information/phononwidget.h 1e1ea37 
>   dolphin/src/panels/information/phononwidget.cpp 5f0c111 
> 
> Diff: http://git.reviewboard.kde.org/r/104988/diff/
> 
> 
> Testing
> -------
> 
> with no more regressions.
> 
> 
> Thanks,
> 
> Hui Ni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120519/d451c5ba/attachment.htm>