Review Request: show video previews according to file content instead of mimetype string

Commit Hook null at kde.org
Sat May 19 21:30:50 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104988/#review13987
-----------------------------------------------------------


This review has been submitted with commit 3faed364339edef012b04db23fea055e7ff26121 by Peter Penz to branch master.

- Commit Hook


On May 19, 2012, 6:54 a.m., Hui Ni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104988/
> -----------------------------------------------------------
> 
> (Updated May 19, 2012, 6:54 a.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string.
> There are container formats which can be either audios or videos.
> Besides, the rmvb video files have mimetype of "application/vnd.rn-realmedia", and these files can be recognized as videos correctly now.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.h 1d964f5 
>   dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 
>   dolphin/src/panels/information/phononwidget.h 1e1ea37 
>   dolphin/src/panels/information/phononwidget.cpp 5f0c111 
> 
> Diff: http://git.reviewboard.kde.org/r/104988/diff/
> 
> 
> Testing
> -------
> 
> with no more regressions.
> 
> 
> Thanks,
> 
> Hui Ni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120519/dddcfa5f/attachment.htm>


More information about the kfm-devel mailing list