Review Request: Respect the style's icon sizes

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105548/#review15849
-----------------------------------------------------------

Ship it!


Thanks Christoph for the patch, looks good from my point of view! I'm not sure if all users will consider this a full fix for the  issue (because the way to change the icon size is different from what it used to be),but it is definitely a great improvement if you commit this to 4.9 and master. I'll leave it up to  you if you implement David's suggestion,I don't have any strong opinion about this.

- Frank Reininghaus


On July 13, 2012, 11:54 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105548/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 11:54 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> KDE allows setting icon sizes, which KDE styles (such as Oxygen) respect. On other platforms (e.g. Mac OS X), the sizes will be taken from the platforms' style.
> 
> 
> This addresses bug 301959.
>     http://bugs.kde.org/show_bug.cgi?id=301959
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistview.cpp f4d05dc 
> 
> Diff: http://git.reviewboard.kde.org/r/105548/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120714/e93fdf7c/attachment.htm>