Review Request: Respect the style's icon sizes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105548/#review15820
-----------------------------------------------------------


The problem is that with qt-only widget styles, the KDE settings won't be followed.
To fix that, you could use KIconLoader::global()->currentSize( KIconLoader::Small ) instead of the style API (code taken from oxygenstyle.cpp).

[On the other hand I think nowadays the icon size configuration GUI has been moved together with the style, so it's clear that one needs oxygen for that? Not sure.]

I'm not really objecting, feel free to commit if you think it's ok that the widget style decides, in the end (I guess this issue with the user settings exists in many other places).

- David Faure


On July 13, 2012, 11:54 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105548/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 11:54 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> KDE allows setting icon sizes, which KDE styles (such as Oxygen) respect. On other platforms (e.g. Mac OS X), the sizes will be taken from the platforms' style.
> 
> 
> This addresses bug 301959.
>     http://bugs.kde.org/show_bug.cgi?id=301959
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistview.cpp f4d05dc 
> 
> Diff: http://git.reviewboard.kde.org/r/105548/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120713/be97fa49/attachment.htm>