Review Request: Don't make items invisible when turning off previews

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103731/#review9955
-----------------------------------------------------------


This review has been submitted with commit cc8f5b4939062df44ce0bd314ac4ae04973b9830 by Frank Reininghaus to branch KDE/4.8.

- Commit Hook


On Jan. 18, 2012, 11:35 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103731/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 11:35 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The problem is in KItemListView::doLayout(): This function assumes that firstVisibleIndex is a constant.
> 
> However, if the view is scrolled to the bottom with previews enabled, and then previews are disabled (and the icon size is much smaller without previews), this function changes the scroll offset, which also changes the the first visible index. Using the unchanged variable causes trouble later on (i.e., it makes items which are actually inside the view area invisible).
> 
> lastVisibleIndex is not needed before the scroll offset change and is const after that, so I think it makes sense to move its calculation.
> 
> 
> This addresses bug 291841.
>     http://bugs.kde.org/show_bug.cgi?id=291841
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp b6af428 
> 
> Diff: http://git.reviewboard.kde.org/r/103731/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120119/840de263/attachment.htm>