Review Request: Don't make items invisible when turning off previews

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103731/#review9940
-----------------------------------------------------------

Ship it!


Frank, I really like reading your analyses as I always know that there comes a good patch afterwards that fixes everything. Thanks :-)

- Peter Penz


On Jan. 18, 2012, 11:35 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103731/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 11:35 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The problem is in KItemListView::doLayout(): This function assumes that firstVisibleIndex is a constant.
> 
> However, if the view is scrolled to the bottom with previews enabled, and then previews are disabled (and the icon size is much smaller without previews), this function changes the scroll offset, which also changes the the first visible index. Using the unchanged variable causes trouble later on (i.e., it makes items which are actually inside the view area invisible).
> 
> lastVisibleIndex is not needed before the scroll offset change and is const after that, so I think it makes sense to move its calculation.
> 
> 
> This addresses bug 291841.
>     http://bugs.kde.org/show_bug.cgi?id=291841
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp b6af428 
> 
> Diff: http://git.reviewboard.kde.org/r/103731/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120119/e17f1019/attachment.htm>