Review Request: Add support for automatically set url location bar to non-editable when focus out

Xuetian Weng wengxt at gmail.com
Sun Dec 16 13:29:34 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107748/
-----------------------------------------------------------

(Updated Dec. 16, 2012, 1:29 p.m.)


Review request for Dolphin and Rodrigo Fernandes.


Changes
-------

use the exist "Editable Location bar" to control this behavior.


Description
-------

after edit the url the location bar always kept editable is very annoying. since crumb-bread location is much more useful for navigation.

BTW this is also the default behavior in Finder (Mac FM) AFAIK.

This patch add support to reset the location bar to non-editable when it's focus out, and also add an option to set it back to the old behavior.


This addresses bug 157593.
    http://bugs.kde.org/show_bug.cgi?id=157593


Diffs (updated)
-----

  dolphin/src/dolphinviewcontainer.h e2d1b18 
  dolphin/src/dolphinviewcontainer.cpp c27550a 

Diff: http://git.reviewboard.kde.org/r/107748/diff/


Testing
-------

localily tested, no problem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121216/81ba4dcb/attachment.htm>


More information about the kfm-devel mailing list