Review Request: Add support for automatically set url location bar to non-editable when focus out

[Xuetian Weng]

> On Dec. 16, 2012, 12:06 p.m., Emmanuel Pescosta wrote:
> > Great feature, Thanks :)
> > 
> > I tested the patch and it worked without problems.
> > 
> > But I discovered a small usability bug - When the user enables "Editable location bar" and "Automatically set location bar to non-editable if focus out" then the behavior of Dolphin is wrong, because in this case the location bar should always be in the editable-mode.
> > 
> > In my mind, the behavior of "Automatically set location bar to non-editable if focus out" should be the common behavior of the location bar, when "Editable location bar" is disabled. And when "Editable location bar" is enabled, the location bar should always stay in the editable-mode (current behavior) => With this approach, we can remove the settings-option "Automatically set location bar to non-editable if focus out".
> > 
> > What do you think?

I'm not sure, the old behavior is only set the default state. And since the default state is remembered upon user operation, it's kinds of persist.

So one of this option control the "default" status, the other control the behavior, which leads to 2 x 2 combinition.

I can't really say all of those combinitions useful.. and you're right, "Editable location bar" checked can be the old behavior while unchecked can use this new behavior. Since other two combinitions doesn't really make much sense. Less option is always better :)


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107748/#review23521
-----------------------------------------------------------


On Dec. 16, 2012, 5:04 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107748/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 5:04 a.m.)
> 
> 
> Review request for Dolphin and Rodrigo Fernandes.
> 
> 
> Description
> -------
> 
> after edit the url the location bar always kept editable is very annoying. since crumb-bread location is much more useful for navigation.
> 
> BTW this is also the default behavior in Finder (Mac FM) AFAIK.
> 
> This patch add support to reset the location bar to non-editable when it's focus out, and also add an option to set it back to the old behavior.
> 
> 
> This addresses bug 157593.
>     http://bugs.kde.org/show_bug.cgi?id=157593
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h e2d1b18 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
>   dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7 
>   dolphin/src/settings/startup/startupsettingspage.h 29cdc63 
>   dolphin/src/settings/startup/startupsettingspage.cpp 633cdac 
> 
> Diff: http://git.reviewboard.kde.org/r/107748/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121216/4944ea4a/attachment.htm>