Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Dec 13 16:04:15 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107305/
-----------------------------------------------------------

(Updated Dec. 13, 2012, 4:04 p.m.)


Review request for Dolphin, David Faure and Frank Reininghaus.


Changes
-------

* Made the DolphinView::slotItemsActivated(const QSet<int>& indexes) code a little bit easier. 
* Removed the foreach loop.


Description
-------

Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected


This addresses bug 304299.
    http://bugs.kde.org/show_bug.cgi?id=304299


Diffs (updated)
-----

  dolphin/src/dolphinpart.h e5693b3 
  dolphin/src/dolphinpart.cpp ccc91fd 
  dolphin/src/dolphinviewcontainer.h 0300273 
  dolphin/src/dolphinviewcontainer.cpp 6e99437 
  dolphin/src/views/dolphinview.h 6d15ebf 
  dolphin/src/views/dolphinview.cpp ea64a04 

Diff: http://git.reviewboard.kde.org/r/107305/diff/


Testing
-------

Tested with Gwenview, works fine.

# Dolphin 2.1: Start one Gwenview instance for each selected image
# Patched Dolphin: Open all selected images in one Gwenview instance


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121213/b50369da/attachment.htm>


More information about the kfm-devel mailing list