Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107305/#review23399
-----------------------------------------------------------



dolphin/src/views/dolphinview.cpp
<http://git.reviewboard.kde.org/r/107305/#comment18003>

    Removing items from a container inside foreach/Q_FOREACH is safe, given that foreach iterates over a copy of the container.
    
    (refcounted, of course, so in practice this "copying" is fast, and the first non-const operation over the container will detach)


- David Faure


On Dec. 12, 2012, 6:29 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107305/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:29 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected
> 
> 
> This addresses bug 304299.
>     http://bugs.kde.org/show_bug.cgi?id=304299
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.h e5693b3 
>   dolphin/src/dolphinpart.cpp ccc91fd 
>   dolphin/src/dolphinviewcontainer.h 0300273 
>   dolphin/src/dolphinviewcontainer.cpp 6e99437 
>   dolphin/src/views/dolphinview.h 6d15ebf 
>   dolphin/src/views/dolphinview.cpp ea64a04 
> 
> Diff: http://git.reviewboard.kde.org/r/107305/diff/
> 
> 
> Testing
> -------
> 
> Tested with Gwenview, works fine.
> 
> # Dolphin 2.1: Start one Gwenview instance for each selected image
> # Patched Dolphin: Open all selected images in one Gwenview instance
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121213/52c22215/attachment.htm>