Review Request: Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/
-----------------------------------------------------------

(Updated Dec. 11, 2012, 10:59 p.m.)


Review request for Dolphin, David Faure and Frank Reininghaus.


Changes
-------

Return a KonqOperations object instead of CopyJob object to Dolphin (Much lesser code on the Dolphin side :) )

Encapsulated the whole paste stuff a little bit more in KonqOperations (According to Davids suggestions)

And thanks for your review!


Description
-------

Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.


This addresses bug 233335.
    http://bugs.kde.org/show_bug.cgi?id=233335


Diffs (updated)
-----

  dolphin/src/views/dolphinview.h 6d15ebf 
  dolphin/src/views/dolphinview.cpp ea64a04 
  lib/konq/konq_operations.h b82feb4 
  lib/konq/konq_operations.cpp e0f1ade 

Diff: http://git.reviewboard.kde.org/r/107351/diff/


Testing
-------

1. Open a test folder with Dolphin.
2. Create the test files:
    2.1. Open Dolphin’s terminal (F4).
    2.2. Run “mkdir folder ; touch a b folder/b c d”.
    2.3. Close Dolphin’s terminal (F4).
3. In the current folder, select the four empty files (a, b, c, d) and copy them (Ctrl+C).
4. Enter the “folder” folder.
5. Paste the files (Ctrl+V).
    5.1. When asked for a new name for “b”, enter “b2” and hit Enter to continue.

Result:
Items “a”, “b2”, “c”, “d” are selected

Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121211/3dfc7d81/attachment.htm>