Review Request: Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/#review22975
-----------------------------------------------------------



lib/konq/konq_operations.cpp
<http://git.reviewboard.kde.org/r/107351/#comment17555>

    This method can either create a put job (see kio/paste.cpp, putDataAsyncTo) or a copy job, so I don't really like returning a CopyJob* that could be NULL depending on what happened internally. What if we needed to do something with the put job, how would we return it then?
    
    I think KonqOperations could encapsulate this a little bit more, and provide its own signal for this. Just like in doDrop, return a KonqOperations * instead, and connect to that in dolphin.
    
    Sune points out that changing a method's return type can create trouble at runtime (new app compiled with new lib, old lib found at runtime... boom), and therefore suggests adding a new method which returns a KonqOperations*, and letting doPaste call that new method (and ignore the return value).


- David Faure


On Nov. 30, 2012, 4:09 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107351/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 4:09 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names)
> 
> Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
> 
> 
> This addresses bug 233335.
>     http://bugs.kde.org/show_bug.cgi?id=233335
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 1feaf0f 
>   dolphin/src/views/dolphinview.cpp e677613 
>   lib/konq/konq_operations.h b82feb4 
>   lib/konq/konq_operations.cpp e0f1ade 
> 
> Diff: http://git.reviewboard.kde.org/r/107351/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a test folder with Dolphin.
> 2. Create the test files:
>     2.1. Open Dolphin’s terminal (F4).
>     2.2. Run “mkdir folder ; touch a b folder/b c d”.
>     2.3. Close Dolphin’s terminal (F4).
> 3. In the current folder, select the four empty files (a, b, c, d) and copy them (Ctrl+C).
> 4. Enter the “folder” folder.
> 5. Paste the files (Ctrl+V).
>     5.1. When asked for a new name for “b”, enter “b2” and hit Enter to continue.
> 
> Result:
> Items “a”, “b2”, “c”, “d” are selected
> 
> Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121204/c6613031/attachment.htm>