Review Request: Handle missing enum in vcs function of dolphin
Commit Hook
null at kde.org
Wed Aug 29 12:44:39 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106239/#review18228
-----------------------------------------------------------
This review has been submitted with commit bddd101b84515bae3c72ee95603957190f4b0f02 by Weng Xuetian to branch master.
- Commit Hook
On Aug. 27, 2012, 8:16 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106239/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2012, 8:16 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Some KVersionControlPlugin2 enum is not handled. and will hit Q_ASSERT. Though not sure whether the missing enum icon name, but seems they shouldn't have an overlay icon, using color looks enough.
>
>
> Diffs
> -----
>
> dolphin/src/views/dolphinfileitemlistwidget.cpp 43030c6
>
> Diff: http://git.reviewboard.kde.org/r/106239/diff/
>
>
> Testing
> -------
>
> No problem here.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120829/c5cba8e1/attachment.htm>
More information about the kfm-devel
mailing list