Review Request: Handle missing enum in vcs function of dolphin

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106239/#review18225
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks good!

- Frank Reininghaus


On Aug. 27, 2012, 8:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106239/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 8:16 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Some KVersionControlPlugin2 enum is not handled. and will hit Q_ASSERT. Though not sure whether the missing enum icon name, but seems they shouldn't have an overlay icon, using color looks enough.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinfileitemlistwidget.cpp 43030c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106239/diff/
> 
> 
> Testing
> -------
> 
> No problem here.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120829/1bcf6836/attachment.htm>