Review Request: Dolphin: make --select scroll to the item need to be selected

Xuetian Weng wengxt at gmail.com
Sun Aug 26 13:57:29 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106209/
-----------------------------------------------------------

(Updated Aug. 26, 2012, 12:57 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Yeah, I didn't notice that markUrlAsCurrent only used in these places. Done.


Description
-------

dolphin and konqueror provides "--select" to select items in arguments, but its not very useful since it doesn't scroll to the corresponding item. This patch is supposed to fix this problem.


Diffs (updated)
-----

  dolphin/src/dolphinpart.cpp d1626e5 
  dolphin/src/views/dolphinview.h 1ad4d6c 
  dolphin/src/views/dolphinview.cpp 233c700 

Diff: http://git.reviewboard.kde.org/r/106209/diff/


Testing
-------

No problem here and work as expected.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120826/54770099/attachment.htm>


More information about the kfm-devel mailing list