Review Request: Dolphin: make --select scroll to the item need to be selected

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106209/#review18016
-----------------------------------------------------------


Thanks for the patch, looks good!

One idea to improve it: It looks like DolphinMainWindow::markUrlAsCurrent() would not be needed any more if your patch is applied. Therefore, I would suggest to not add a new function DolphinView::markUrlNeedToScrollTo(), but just replace the line "m_currentItemUrl = url;" in markUrlAsCurrent() by "observeCreatedItem(url);".


- Frank Reininghaus


On Aug. 26, 2012, 4:36 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106209/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 4:36 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> dolphin and konqueror provides "--select" to select items in arguments, but its not very useful since it doesn't scroll to the corresponding item. This patch is supposed to fix this problem.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp d83c9de 
>   dolphin/src/dolphinpart.cpp d1626e5 
>   dolphin/src/views/dolphinview.h 1ad4d6c 
>   dolphin/src/views/dolphinview.cpp 233c700 
> 
> Diff: http://git.reviewboard.kde.org/r/106209/diff/
> 
> 
> Testing
> -------
> 
> No problem here and work as expected.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120826/9eb35a5c/attachment.htm>