[PATCH] Should we add 'Konqueror File Manager' to the menu

[James Richard Tyrer]

David Faure wrote:
> On Wednesday 24 December 2008, James Richard Tyrer wrote:
>> Per: DF's request, this is a patch to do one thing: add Konqueror
>> File Manager (KFM) to the menu.
>> 
>> So, this is a simple question: should it be on the menu?
>> 
>> I note that Dolphin is on the menu.  Therefore, I think that KFM
>> should also be on the menu.
>> 
>> I realize that there are other ways to open a file manager window.
>>  These are OK for local use, but a file manager is also used for
>> network and web (e.g. FTP).
>> 
>> I find that in KDE that I open KFM both ways -- either with a
>> directory icon or with the Konqueror icon.
>> 
>> IAC, I think that to be consistent that if we have Dolphin on the
>> menu that we should also have KFM on the menu.
> 
> This seems reasonable to me (giving people choice), but I noticed
> that we don't need a new kfm.desktop file for this, we have in
> konqueror a Home.desktop already doing exactly that (same Exec line
> as your kfm.desktop).

To say the least, I am surprised.  I also note that the Exec in 
Home.desktop will not open the $HOME directory.  It will open whatever 
directory is set as the default URL in the  filemanagement profile.  It 
appears that this bug was introduced in 57093.  It was fixed in 189840 
but was then reverted in 189861.  Very odd.  Probably the bug wasn't 
noticed till now because you won't find it unless you change the defaults.

> But it was marked as NoDisplay=true by Jonathan Riddell in 789263,
> with the commit log "hide from apps menu by default, already in
> Computer menu,

Yes, that is correct, it is already in the Computer menu.  So, I am not 
sure why he didn't simply remove it if it is no longer needed.  But, 
perhaps something uses it.

> see kde-core-devel 'Kubuntu Settings in KDE' thread" Ah, he means the
> "Home" link, but if your default filemanager is dolphin then that one
> opens dolphin.

Yes, the folders in the Computer menu open your choice of default for 
file manager.  However, they open it with the directory of the folder 
you selected.

> Well that's easy to change now that we have the file manager
> configuration in `kcmshell4 componentchooser`.... We provide choice
> already, as a global setting - I don't think we need to care for the
> very rare case of someone wanting to use -both- dolphin and kfm as
> filemanagers?
> 
Well, I am probably one of them.  But, as I said in my posting, I 
recognize that you can open the file manager by clicking on directories. 
  This also works if you add directories to the desktop as I have.  So, 
I wasn't really sure it it was necessary to be able to open KFM as an 
application.  If you think not, that is OK.  This issue is a design 
choice and although I do have an opinion, this is a question of opinion 
and the choice is ultimately yours.

However, I then ask the question of why Dolphin is on the menu as an 
application rather than just accessible by clicking on a directory 
folder in the Computer menu.  My original thought was that they should 
both be the same.  So, if Dolphin is available in the System section of 
the Menu, then KFM should be also, or Dolphin should be made NoDisplay=true.

If you are going to add KFM to the menu, you will still need a new 
'desktop' file since the strings need to be different.

-- 
JRT