Fwd: KHTMLView and QToolTip

[Darío Andrés]

---------- Forwarded message ----------
From: Martin Koller <kollix at aon.at>
Date: Sun, Aug 30, 2009 at 9:35 AM
Subject: KHTMLView and QToolTip
To: kde-core-devel at kde.org


Hi,

in checking https://bugs.kde.org/show_bug.cgi?id=95628
I found that KHTMLView/Part does not hide the tooltip when a new HTML
page is passed to it.
So I propose the following:

Index: khtml_part.cpp
===================================================================
--- khtml_part.cpp      (Revision 1016745)
+++ khtml_part.cpp      (Arbeitskopie)
@@ -114,6 +114,7 @@
 #include <kurllabel.h>

 #include <QtGui/QClipboard>
+#include <QtGui/QToolTip>
 #include <QtCore/QFile>
 #include <QtCore/QMetaEnum>
 #include <QtGui/QTextDocument>
@@ -1987,6 +1988,9 @@

 void KHTMLPart::begin( const KUrl &url, int xOffset, int yOffset )
 {
+  if ( d->m_view->underMouse() )
+    QToolTip::hideText();  // in case a previous tooltip is still shown
+
  // No need to show this for a new page until an error is triggered
  if (!parentPart()) {
    removeJSErrorExtension();


But there is also the problem that the ToolTip does not hide when one
moves the content e.g. via the
keyboard.
I didn't find the correct place to add QToolTip::hideText(); ...

Any ideas ?
Is the above fix ok ?

--
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail
         /\                        - against microsoft attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20090830/f5b12d8e/attachment.sig>