[PATCH] Google Suggest for Konqueror Searchbar

Fredy Yanardi fyanardi at gmail.com
Fri Apr 24 06:20:41 BST 2009


Hi Germain,

> you did not attach the files 'GoogleSuggest.cpp' and 'GoogleSuggest.h'...
>
> Speaking of those, as a general question on the design of your patch, why did
> you specifically used the names "Google" for REST services that could be
> provided by many search engines beside this specific one?
>
> It seems this kind of service is simple to map, so why not abstract that
> functionality into a generic class, even if it only contains one provider at
> first?
>
> For instance, after just a cursory search, I can find at least one other
> similar REST api:
>
> http://developer.yahoo.com/search/web/V1/relatedSuggestion.html

Yes, you're right. This kind of functionality can be implemented as a
generic class that takes in some parameters. And each service can be
mapped to a search provider. I just found out that mozilla guys use
xml to represent their search provider + suggestion service:
http://mxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/searchplugins/.
Maybe we can also do something similar to that. I'll take a look again
and will think about the actual implementation after I get back home.

>
> that could be used to extend your work...

Thanks for your suggestion.

Best Regards,

Fredy
> Greetings,
> Germain
>




More information about the kfm-devel mailing list