[PATCH] Google Suggest for Konqueror Searchbar

[Germain Garand]

Le jeudi 23 avril 2009, Fredy Yanardi a écrit :
> Hi all,
>
> This patch implements a google suggest feature for Konqueroer's
> Searchbar. It will only send request for suggestion to Google if
> current search provider is google and the search is not a local
> search.
>
> It is always enabled for google search provider, but I'll work on a
> context menu entry to disable this feature.

Hi Fredy,

you did not attach the files 'GoogleSuggest.cpp' and 'GoogleSuggest.h'...

Speaking of those, as a general question on the design of your patch, why did 
you specifically used the names "Google" for REST services that could be 
provided by many search engines beside this specific one?

It seems this kind of service is simple to map, so why not abstract that 
functionality into a generic class, even if it only contains one provider at 
first?

For instance, after just a cursory search, I can find at least one other 
similar REST api:

http://developer.yahoo.com/search/web/V1/relatedSuggestion.html

that could be used to extend your work...

Greetings,
Germain