[Patch] Support for undo closed window

[Eduardo Robles Elvira]

El Lunes 17 Marzo 2008, David Faure escribió:
> Now I have to look at the patch, because I'm unhappy that it touches
> libkonq. Why does it touch libkonq?
> Did you forget our decision decision for the undo-close-tab feature?
> We added a KonqUndoManager which would take care of the konq-level features
> in order to keep KonqFileUndoManager (in libkonq) clean of such things.
> I still want to be able to move KonqFileUndoManager to kdelibs one day....
> I see that this time the changes to it are more generic, but I dislike all
> that unsafe-at-compile-time QVariant stuff, when we can do things in a more
> straight-forward way.
>
> Why doesn't KonqUndoManager talk to a singleton for adding "undo close
> window" when available? I think you're basically misusing
> KonqFileUndoManager as that singleton. I see no reason why the closed
> windows have to be stored into the totally-unrelated KonqFileUndoManager.

I like your idea, it's simpler and more elegant! I will implement modify it to 
work that way and thus eliminating the signal I use for message passing 
between konqueror windows using the QVariant stuff. 

However there are some modifications in libkonq that I think you still should 
take a look, he ones which give support for custom file operation commands. I 
haven't provided an example though, because I didn't use it (undo closed 
windows were not of that kind). Probably I should have separated that in a 
different patch..

> All this refcounting in KonqUndoManager wouldn't be necessary if the
> closed-window-items were in that singleton; then they would be deleted at
> the end of the process already, without this ref counting. Even better, if
> konq is kept for preloading you could still reopen old closed windows after
> closing all windows and then reopening a window the normal way (to get the
> menu item :).
>
> Other than that, the feature is great to have, of course.

Ok be tunned for the fix! I will paste it here before commiting ;-).

-- 
"The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man." (George Bernard Shaw)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080317/552e166a/attachment.sig>