[patch] Konq bookmarks sidebar bug
Philip Rodrigues
philip.rodrigues at lincoln.ox.ac.uk
Thu Jun 26 09:07:14 BST 2008
Hi,
> > Can anyone see any problems with the patch? If not, can I commit it?
>
> Indeed, looks like a porting error.
> QStringList::split should have been ported to
> QString::split(, QString::SkipEmptyParts);
> This might be safer than accessing [0], btw (e.g. if the
> address is empty for some reason).
Ah yes, Pino mentioned to me that QString::skipEmptyParts might be a better
way to do it - I'll try that, and if it works, I'll commit unless someone
says otherwise.
Regards,
Philip
More information about the kfm-devel
mailing list