[patch] Konq bookmarks sidebar bug

[David Faure]

On Monday 23 June 2008, Philip Rodrigues wrote:
> Hi,
> The attached patch, to be applied in 
> kdebase/apps/konqueror/sidebar/trees/bookmark_module/ ,  seems to fix a 
> couple of bugs that affect the bookmarks in the sidebar. The problem is that 
> KonqSidebarBookmarkModule::findByAddress, which converts an address in the 
> bookmarks tree like "/5/6/7" into a pointer to the appropriate list item was 
> recursing one time too many and so returning the wrong thing.
> 
> Can anyone see any problems with the patch? If not, can I commit it?

Indeed, looks like a porting error.
QStringList::split should have been ported to QString::split(, QString::SkipEmptyParts);
This might be safer than accessing [0], btw (e.g. if the address is empty for some reason).

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).