[PATCH}Re: Konqueror throbber size -- too small and doesn't resize

[Rafael Fernández López]

Hi,

Comments about the patch.

1) I don't see the point of getting out a very valid number got from the 
style.
2) Hardcoded values => evil.

Despite I cannot reproduce this issue I am pretty sure there is a better way 
of fixing this issue.

Please, instead of hardcoded values use KIconLoader:: enums for icon sizes.

> Well, I looked through the Qt dox and the attached patch should work.
> Unfortunately, there appears to be a bug in Qt.  Still, it works better
> than what we have now, and will improve if the Qt bug is fixed.

What bug in Qt, what will improve if the bug is fixed ?

If you found a bug in Qt and say "will improve if the Qt bug is fixed"... I 
guess you reported it to qt-bugs, or is is going to be fixed by itself ? :)

BTW, cross posting is not fun :)


Regards,
Rafael Fernández López.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080608/1a94c1f9/attachment.sig>
-------------- next part --------------
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<