[PATCH}Re: Konqueror throbber size -- too small and doesn't resize

[James Richard Tyrer]

James Richard Tyrer wrote:
> This is not going very well.
> 
> With 12 point type, the Menu bar is 30 pixels tall.  However, if I
> use a throbber icon that is larger than 20 pixels, the Menu bar gets
> taller.
> 
> And using the pixel height of the font:
> 
> int size = QFontInfo(KGlobalSettings::menuFont()).pixelSize();
> 
> seems to have problems as well since the value is only 17 (which is 
> correct).
> 
> So, I have the attached diff that is only going to help those with
> high resolution screens.
> 
> This leaves me with questions.
> 
> 17 pixels is correct for 12 points @ 100 DPI but where does the extra
> 3 pixels come from and is there a way to obtain this value?
> 
> Is there any way to use a throbber that is larger than Qt seems to
> think will fit in the Menu bar?
> 
> See screen shot which shows a 20x20 throbber (I simply set size = 20
> to try it).  There is clearly room for a larger throbber -- 22x22
> would look OK.
> 
Well, I looked through the Qt dox and the attached patch should work.
Unfortunately, there appears to be a bug in Qt.  Still, it works better 
than what we have now, and will improve if the Qt bug is fixed.

Should I commit this?

-- 
JRT


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: throbber0.diff
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080608/0b9f2383/attachment.ksh>
-------------- next part --------------
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<