obsolete qpoint member in KHTMLWidgetPrivate

Germain Garand germain at ebooksfrance.org
Tue Jul 29 02:58:47 BST 2008


Le lundi 21 juillet 2008, Slava Tokarev a écrit :
> Hi,
>
> I have a small patch that removes QPoint m_pos & QPoint setPos()
> method from KHTMLWidgetPrivate. I hope that could give some better
> memory usage. The only class that's using them is ScrollBarWidget. So
> in my aproach QPoint goes directly to ScrollBarWidget.
> Is it ok to commit? I've tested it on several pages with vertical
> scrolling and it works as expected.
>

Hi Slava!

While the patch is indeed harmless, I don't think it'd be going in the right 
direction... the point of this member is to be able to ask their absolute 
position to any khtml widget, regardless of whether they have an associated 
RenderWidget or not (case of scrollbars).

With that patch, one could no longer call 
absolutePos() and be sure to have a meaningful result regardless of the khtml 
widget type.

It would need a really significant memory saving to be worth, and I don't 
think it's the case here (widgets are typically few and big, so the QPoint is 
negligible IMO)

Greetings,
Germain

---
short on time until August 10th




More information about the kfm-devel mailing list