[PATCH] Tiny patch for spring-loaded folders in Dolphin

[Simon St James]

On Tuesday 12 August 2008 07:06:56 you wrote:
> Hi Simon,
>
> Am Monday, 11. August 2008 20:40:40 schrieb Simon St James:
> > Hi Peter,
> >
> > Call me Jack ;) Updated patch with your feedback included attached! No
> > additional bugs fixed, alas.
>
> Thanks Simon (Jack?), the patch looks good and I'll commit it during this
> week (I should have some time again for Dolphin on Thursday evening).

Jack Bauer (I made it within 24 hours ;)).  Great to hear it's good enough to 
be committed.

> > On Monday 11 August 2008 09:34:04 you wrote:
>
> [...]
>
> > > Maybe it would be worth checking how Konqueror did this in KDE 3.
> > > Konqueror also could exchange views per directory level.
> >
> > Based on a quick experiment, it simply keeps using the same view mode
> > when using auto-entry.  This would be a possible strategy to adopt,
> > except that it wouldn't help with ColumnView :/
>
> I think respecting the used view mode is a must-have, but I have no problem
> that we postpone solving this issue a little bit. If it's OK for you, I can
> take over solving this part of the issue - I'm quite interested how this
> can be solved in a nice manner ;-) For sure if you want to solve this
> yourself, just go ahead.

I've got an idea that is slightly less hackish than the others; I'll implement 
it and post it if it works to see if it gives you any ideas :)

> [...]
>
> > No problem.  Important detail I didn't mention: this is if I drag from
> > one pane over a folder in the other pane.  If I just restrict myself to
> > one pane, it's OK.
>
> Ah, this explains the issue. This issue can be solved by taking care to
> activate the other view first before the drop event comes in. I can also
> take over this part of the issue if you want.

Ok, I'll happily leave this one to you :)

> I've already a guilty conscience because you started with a "tiny patch"
> and it got already quite a lot of work. I think it's important that
> contributing for KDE stays fun: If you want to concentrate on e. g. the
> previews inside tooltips please just do it, I'm confident that I can fix
> the remaining parts of the spring-loaded folders :-)

No need to feel guilty; it's been a great intro to KDE development and a good 
challenge/ practice!  It's a feature I really want, too.

Best Wishes,
Simon

> [...]
>
> > Aha! I didn't realise this, and this is a game-changer: I'm completely in
> > agreement, now!  It even solves a corner case that had just occurred to
> > me (my approach wouldn't take into account whether the "Expandable
> > Folders" setting in the Details Mode settings dialog changed).
>
> Great :-)
>
> Best regards,
> Peter