[PATCH] Tiny patch for spring-loaded folders in Dolphin
Peter Penz
peter.penz at gmx.at
Tue Aug 12 07:06:56 BST 2008
Hi Simon,
Am Monday, 11. August 2008 20:40:40 schrieb Simon St James:
> Hi Peter,
>
> Call me Jack ;) Updated patch with your feedback included attached! No
> additional bugs fixed, alas.
Thanks Simon (Jack?), the patch looks good and I'll commit it during this week
(I should have some time again for Dolphin on Thursday evening).
> On Monday 11 August 2008 09:34:04 you wrote:
[...]
> > Maybe it would be worth checking how Konqueror did this in KDE 3.
> > Konqueror also could exchange views per directory level.
>
> Based on a quick experiment, it simply keeps using the same view mode when
> using auto-entry. This would be a possible strategy to adopt, except that
> it wouldn't help with ColumnView :/
I think respecting the used view mode is a must-have, but I have no problem
that we postpone solving this issue a little bit. If it's OK for you, I can
take over solving this part of the issue - I'm quite interested how this can
be solved in a nice manner ;-) For sure if you want to solve this yourself,
just go ahead.
[...]
> No problem. Important detail I didn't mention: this is if I drag from one
> pane over a folder in the other pane. If I just restrict myself to one
> pane, it's OK.
Ah, this explains the issue. This issue can be solved by taking care to
activate the other view first before the drop event comes in. I can also take
over this part of the issue if you want.
I've already a guilty conscience because you started with a "tiny patch" and
it got already quite a lot of work. I think it's important that contributing
for KDE stays fun: If you want to concentrate on e. g. the previews inside
tooltips please just do it, I'm confident that I can fix the remaining parts
of the spring-loaded folders :-)
[...]
> Aha! I didn't realise this, and this is a game-changer: I'm completely in
> agreement, now! It even solves a corner case that had just occurred to me
> (my approach wouldn't take into account whether the "Expandable Folders"
> setting in the Details Mode settings dialog changed).
Great :-)
Best regards,
Peter
More information about the kfm-devel
mailing list