patch: padding in form elements

Charles Samuels charles at kde.org
Mon Nov 5 06:07:36 GMT 2007


Hi Germain,

Please take a look at my latest patch. I reworked it quite a bit to workaround 
some unfortunate QStyleSheet behavior.

Also please take a look at the change in render_replaced.cpp - I can't explain 
why it is necessary, and it's really ugly. I think I've ruled out a Qt bug.

Germain Garand wrote, on Thursday 2007 November 01:
> it looks nice for the mechanism but AFAICS this quirky padding shouldn't
> apply to
>
> input[type="radio"], input[type="checkbox"],
> select[size="0"]:not([multiple]), select[size="1"]:not([multiple])
Done in my latest patch.

> Also did you check that it works fine in combination with
> content-box/border-box? I guess it does but better double check that...
> (most form widgets default to border-box in quirk mode).

I gave it a quick spin with "box-sizing: content-box" and it looks to not have 
a significant difference compared to IceWeasel.

Charles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml-input-style-2.diff
Type: text/x-diff
Size: 6917 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20071104/d64565a4/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20071104/d64565a4/attachment.sig>


More information about the kfm-devel mailing list