Clear Web History and KDE Control Center

[David Faure]

On Sunday 23 December 2007, Maksim Orlovich wrote:
> <snip a very helpful report I am not sure of how to best to address at the
> moment, not having had my morning tea>
> 
> > void KonqHistoryManager::notifyClear( QCString )
> > {
> >     clearPending();
> >     m_history.clear();
> >     m_pCompletion->clear();
> >
> >     if ( isSenderOfBroadcast() )
> > 	saveHistory();
> >
> >     KParts::HistoryProvider::clear(); // also emits the cleared() signal
> > }
> >
> >
> > if you remove line "if ( isSenderOfBroadcast() )" history is saved as it
> > should, but I don't know if that line is used for something else.
> 
> The point of that line is so that when one clears the history, only one
> browser instance saves it. That's obviously important for things like
> adding a history entry (people already dislike konqueror saving history to
> often -- and imagine if every single process did it!), in which case the
> instance responsible for the entry is the instance saving it. Perhaps for
> clearing this can be removed, though, since it's hardly a background
> operation. An alternative is perhaps to change the check to:
> 
> if ( isSenderOfBroadcast() ||
> !callingDcopClient()->senderId().startsWith("konqueror") )
>
>
> but then one would have the same multi-write stampede from the KCM,
> anyway. 

Yeah. I think the best solution would be a new DCOP (DBus) method call 
that the KCM calls in one konqueror instance. Then that instance would do the above
and take care of the saving.

> I suppose then the best thing for would indeed be to just remove 
> the check as suggested... Seems like 4.0 behaves the same.

Actually I can't find the "privacy" module anywhere in trunk !?!?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).