Patch for text-overflow:ellipsis

[Leo Savernik]

Am Sonntag, 12. November 2006 16:59 schrieb Allan Sandfeld Jensen:
> I've written/ported this patch for text-overflow: ellipsis, because i think
> it's a really neat feature.

I think so, too.
>
> I just have a few questions before committing:
> 1. Is is nodeAtPoint in render_line correct?
> There seems to be various odd differences between the codebases.

I can't remember any more the intricacies of nodeAtPoint stuff.

> 2. offsetForPoint in InlineTextBox seems to sometimes return an offset and
> position of the letter after the point. I've subtracted one from the result
> to get a usefull position, but is this really how offsetForPoint should
> work?

Well, offsetForPoint is optimised for vertical caret navigation, so by about 
50% it returns the next character. Subtracting one offset will at least 
ensure that characters never spill into the ellipsis.

Btw, have you tested ellipsis with caret navigation? It needn't work 
flawlessly, but it shouldn't crash either.

mfg
	Leo