Patch for text-overflow:ellipsis

Germain Garand germain at ebooksfrance.org
Sun Nov 12 21:54:05 GMT 2006


Le Dimanche 12 Novembre 2006 16:59, vous avez écrit :
> Hi
>
> I've written/ported this patch for text-overflow: ellipsis, because i think
> it's a really neat feature.
>

nice!

> I just have a few questions before committing:
> 1. Is is nodeAtPoint in render_line correct?
> There seems to be various odd differences between the codebases.

well yes, its supposed to be mostly correct.
WC's is more clean and fine grained though, as it proceeds with 3 distinct 
phases (hitTest stuff). It would be worth merging some day.

> 2. offsetForPoint in InlineTextBox seems to sometimes return an offset and
> position of the letter after the point. I've subtracted one from the result
> to get a usefull position, but is this really how offsetForPoint should
> work?
>

this is Leo's code I think.. I don't know anything about it.

Greetings,
Germain




More information about the kfm-devel mailing list