[PATCH] Bugfixes for profiles and preloading.

[Emanuele Tamponi]

My webpage is now up :)

> - there's a bug in your patch. The block after the if() in konq_misc.cc
> that your patch changes is the block that reuses a preloaded instance. If
> you decide not to reuse KonqMainWindow::preloadedWindow() because it uses
> another profile you still need to do at least some of that work - delete
> this old window if any, and do both the KonqMainWindow::setPreloaded* calls
> to do cleanup.

Yes you're right... I'll add that code.

> - Konqueror preloading is there to improve perceived startup performance by
> reusing saved konqueror process and KonqMainWindow in it if possible. Your
> patch sometimes turns off reusing of the window. It might make sense to
> check how big difference that makes and possibly try to reuse that window
> and just switch the profile for it, or first find a preloaded instance with
> a matching xml or something like that. If you just say e.g. "creating the
> new KonqMainWindow costs XYZ, users usually don't switch profiles that
> often and it's just not worth the effort", ok, fine with me. But the
> feature was quite some work (and benefit) to just turn half of it off in
> order to fix a bug almost nobody has noticed for years, _without_ first
> checking.

And here I need to know this: if there are multiple preloaded instances, how 
can I check for all them?
After all, "turn half of it off" isn't true. My check, in normal use, would 
always return TRUE. In 1 case out of 100 (maybe) it will return FALSE: when? 
When, for example, the user will try to load the "Simple Browser" profile. In 
all other cases, my if statement has NO consequences (and the preloaded 
instance will be loaded without problems). But in that 1 case out of 100, the 
behavoir will be right. So I think that you have not to worry :) ...

Before I add that statement, I checked the code, obviously.
createGUI() can be called once. So the profile can't be modified if the 
xmlfile is different. If the xmlfile is different, Konqueror CAN'T be loaded 
from a preloaded instance. So, if xmlfile is different, my "if" will not load 
Konqueror from a preloaded instance. I repeat: this will happen 1 time out of 
100. But it will happen. So my code (once I'll add your cleanup suggestion) 
will not have performance issues.

Maybe that I and you are saying the same thing... I'm not really good in 
English :) So maybe you meant the same thing I wrote here, in your last 
email...

Let me know :)
Bye,
Emanuele