[PATCH] Icons for: Tab functions

[David Faure]

On Thursday 06 April 2006 00:10, David Faure wrote:
> On Wednesday 05 April 2006 22:41, David Faure wrote:
> > On Wednesday 05 April 2006 07:51, James Richard Tyrer wrote:
> > > +    KConfig *config = KGlobal::config();
> > > +    config->setGroup( "FMSettings" );
> > > +    bool newtabsinfront = config->readBoolEntry( "NewTabsInFront", false );
> > 
> > Please use KonqSettings::newTabsInFront() instead.
> ... in kdebase only; not available in kdelibs.
> 
> In kdelibs it's a bit strange to access konqueror's settings from khtml.
> In theory khtml could be used by other browser or pseudo-browser implementations...
> I guess khtml would need a boolean property for this, or more generally a newTabIconName QString property;
> konqueror could then set that property [using dynamic code since it doesn't link to khtml,
> but we have other examples of that already]

OK here's a better solution. Apply /k/browserextension.diff to kdelibs/kparts, then you can use
khtml->browserExtension()->newTabsInFront() from khtml_ext.cpp

Now all that still needs to be done is to set that bool from konqueror....
Hmm, but there it makes req.newTabInFront redundant (where req is a KonqOpenURLRequest),
since it would be equivalent to req.args.newTabsInFront() now...
So I guess the right thing to do would be to change konqueror to remove 
newTabInFront from konq_openurlrequest.h and use req.args.newTabsInFront()/setNewTabsInFront() instead.
No time to do this today though, so if it's too much code change for you I can do it another day,
otherwise feel free to go ahead with that change.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browserextension.diff
Type: text/x-diff
Size: 1931 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20060407/fa1d8bf9/attachment.diff>