[PATCH] Icons for: Tab functions

David Faure faure at kde.org
Wed Apr 5 23:10:22 BST 2006


On Wednesday 05 April 2006 22:41, David Faure wrote:
> On Wednesday 05 April 2006 07:51, James Richard Tyrer wrote:
> > +    KConfig *config = KGlobal::config();
> > +    config->setGroup( "FMSettings" );
> > +    bool newtabsinfront = config->readBoolEntry( "NewTabsInFront", false );
> 
> Please use KonqSettings::newTabsInFront() instead.
... in kdebase only; not available in kdelibs.

In kdelibs it's a bit strange to access konqueror's settings from khtml.
In theory khtml could be used by other browser or pseudo-browser implementations...
I guess khtml would need a boolean property for this, or more generally a newTabIconName QString property;
konqueror could then set that property [using dynamic code since it doesn't link to khtml,
but we have other examples of that already]

PS: no static QStrings please, they take memory and might give trouble in some environments (just remove the static)

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).





More information about the kfm-devel mailing list