[PATCH] Acid2 comment fix

Leo Savernik l.savernik at aon.at
Wed May 18 15:49:29 BST 2005


Am Dienstag, 17. Mai 2005 22:55 schrieb Ivor Hewitt:
[...]
> Ok updated comment parsing.
>
> This passes the acid comment, and passes:-
>
> khtmltests/regression/tests/ecma/comments/comment_ext.html
> khtmltests/html/parser/writecomment.html

Excellent.
>
> However:-
>
> khtmltests/html/parser/comments.html now fails because it gets handled in
> strict mode due to the DOCTYPE tag, and it contains comments which contain
> non "multiple of two" dashes e.g.
>
> "<!---"

D'oh. I lamented about insane websites in my former reply, and now it is 
unveiled that we have created such ourselves :-(

If the testcase says it's strict, it must be strict. Please fix the testcase.
>
> Cheers,

mfg
	Leo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050518/e6fdbb36/attachment.sig>


More information about the kfm-devel mailing list