[PATCH] Acid2 comment fix

[Ivor Hewitt]

On Tuesday 17 May 2005 17:02, Leo Savernik wrote:
> Am Dienstag, 17. Mai 2005 01:37 schrieb Ivor Hewitt:
> > This is a patch for Dave Hyatt's acid comment fix (acid6.txt), the logic
> > looks correct. i.e. the parseComment now ignores anything between paired
> > "--"'s within a comment block.
> > Is there any reason not to have this? or is there a more elegant way of
> > doing this? or is this simply considered an "unnecessary SGML legacy"?
>
> It must be implemented to move further towards total HTML compliance, but
> *only* in strict mode. Otherwise, existing pages will break. (Yes, those
> pages using comments like
> <!----------------------------------------->
>
> :-( )
>
> Otherwise, see the comments the others have given.
>
> mfg
> 	Leo

Ok updated comment parsing.

This passes the acid comment, and passes:-

khtmltests/regression/tests/ecma/comments/comment_ext.html
khtmltests/html/parser/writecomment.html

However:-

khtmltests/html/parser/comments.html now fails because it gets handled in 
strict mode due to the DOCTYPE tag, and it contains comments which contain 
non "multiple of two" dashes e.g.

"<!---"

Cheers,

-- 
Ivor Hewitt.
http://www.ivor.it - tech | http://www.ivor.org - hedge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: acid6b.diff
Type: text/x-diff
Size: 3124 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050517/d1d3d507/attachment.diff>