[PATCH] Konqueror adblock v4

[Martijn Klingens]

On Sunday 01 May 2005 12:55, Leo Savernik wrote:
> Am Sonntag, 1. Mai 2005 11:32 schrieb Martijn Klingens:
> > What about marking the node with some kind of flag/attribute and not show
> > it when it is set? That way a user can toggle the filter without having
> > to reload the page (i.e. less flicker).
>
> If you keep the node from being created, you don't have to reload anything
> (I think you mean relayout, the whole page is never reloaded on DOM
> manipluations).

Well, if you don't create the node and then disable AdBlocK, how are you going 
to re-add the node without fetching the HTML file again? Or do you want to 
make AdBlock maintain a copy of the DOM node so it can re-insert it when the 
filter is toggled? That's what I meant with reload :)

> Marking a node with a flag? We have this "flag" already, it's called
> "display: none" :-)

It's slightly easier, but even then AdBlocK needs to keep track of the nodes 
that it had hidden, because you can't unconditionally switch all display:none 
nodes when toggling the filter. (I was already aware of display:none when I 
wrote the previous mail.)

-- 
Martijn