Bug 97796

[David Faure]

On Tuesday 15 March 2005 14:47, mweilguni at kde.org wrote:
> Am Dienstag, 15. März 2005 14:36 schrieb David Faure:
> > On Tuesday 15 March 2005 11:09, mweilguni at kde.org wrote:
> > > -void RenderRadioButton::slotToggled(bool)
> > > +void RenderRadioButton::slotToggled(bool activated)
> > >  {
> > > -    ref();
> > > -    element()->onChange();
> > > -    deref();
> > > +    if(activated) {
> > > +      ref();
> > > +      element()->onChange();
> > > +      deref();
> > > +    }
> >
> > So, unchecking a checkbox won't emit onchange anymore? This doesn't make
> > sense to me.
> 
> For radiobuttons it makes sense, because a radiobutton cannot be unchecked 
> anymore, only by changing a button in the same group. Both IE and Firefox do 
> not emit onChanged for unchecked buttons, and that's correct IMO if you see a 
> group of radiobuttons more like a selectbox.

Oh, sorry, I missed the fact that this was RenderRadioButton. Looks OK then.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).