Bug 97796

[Koos Vriezen]

Hi,

OT, can you please be a bit more descriptive. Ie. better to describe the
bug than mentioning just a number. Not many of us knows which number is
about what bug, nor has everyone figured out what the real problem is in
BRs (or at least add an url to the BR for convenience).
Also send diffs in with unified context (-u switch of diff). My cvsrc
is:

$ cat ~/.cvsrc
cvs -z4
diff -u3 -p
update -dP
checkout -P

(I didn't made up these settings IIRC, somewhere on devel-kde this is
documented)

Thanks,

Koos

On Tue, Mar 15, 2005 at 08:30:52AM +0100, Mario Weilguni wrote:
> Firefox shows a different behavior here, does anybody know the correct 
> behaviour?
> 
> This patch fixes the bug and gets the same behaviour as firefox:
> Index: rendering/render_form.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/khtml/rendering/render_form.cpp,v
> retrieving revision 1.284
> diff -r1.284 render_form.cpp
> 158d157
> <
> 164a164,167
> >
> >     // prevent firing toggled() signals on initialization
> >     b->setChecked(element->checked());
> >
> 169c172
> < {
> ---
> > {
> 188c191
> < void RenderRadioButton::slotToggled(bool)
> ---
> > void RenderRadioButton::slotToggled(bool activated)
> 190,192c193,197
> <     ref();
> <     element()->onChange();
> <     deref();
> ---
> >     if(activated) {
> >       ref();
> >       element()->onChange();
> >       deref();
> >     }
> 
> What do you think? Can I commit it?
> 
> Mario
>