Bug 97796

Mario Weilguni mweilguni at sime.com
Tue Mar 15 07:30:52 GMT 2005


Firefox shows a different behavior here, does anybody know the correct 
behaviour?

This patch fixes the bug and gets the same behaviour as firefox:
Index: rendering/render_form.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/rendering/render_form.cpp,v
retrieving revision 1.284
diff -r1.284 render_form.cpp
158d157
<
164a164,167
>
>     // prevent firing toggled() signals on initialization
>     b->setChecked(element->checked());
>
169c172
< {
---
> {
188c191
< void RenderRadioButton::slotToggled(bool)
---
> void RenderRadioButton::slotToggled(bool activated)
190,192c193,197
<     ref();
<     element()->onChange();
<     deref();
---
>     if(activated) {
>       ref();
>       element()->onChange();
>       deref();
>     }

What do you think? Can I commit it?

Mario





More information about the kfm-devel mailing list