Popup menu MIME types
David Faure
faure at kde.org
Mon Jan 31 00:12:50 GMT 2005
On Saturday 29 January 2005 20:56, Jonathan Marten wrote:
> On Friday 28 January 2005 10:30, David Faure wrote:
> > Wouldn't it be simpler to determine the mimetype in KHTMLPart, before
> > emitting popupMenu? After all, this is where args.serviceType =
> > QString::fromLatin1( "text/html" ); is hardcoded, and where it should be
> > set correctly.
>
> That's a far better way, many thanks for the pointer. Revised patch attached
> to bug (http://bugs.kde.org/attachment.cgi?id=9348&action=view).
Applied, thanks. I only fixed a few small things like using isEmpty instead of
isNull for strings (isNull will disappear in Qt4), and not testing for is(defaultmimetype)
in case we change mimetype inheritance later - if anything inherits from it that's fine,
it's only ==defaultmimetype that we want to check against there.
--
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kfm-devel
mailing list