MMB on Back/Forward/Up/Home Toolbar and Go menu

[Leo Savernik]

Am Freitag, 14. Januar 2005 20:49 schrieb Daniel Teske:
> > > +void KonqMainWindow::openFilteredURL( const QString & _url, const
> >
> > KonqOpenURLRequest _req)
> >
> > should be "const KonqOpenURLRequest &_req"
> > (note the &).
>
> Okay, I missed that.
>
> > >  {
> >
> > [...]
> >
> > > +    req.newTabInFront = config->readBoolEntry( "NewTabsInFront", false
> > > )
> >
> > xor bool(state & Qt::ShiftButton);
> >
> > Please don't use C99 features in C++. Use ^ instead of xor. Please fix
> > all occurrances.
>
> xor is Standard C++. (Stroustrup "The C++ Programming Language", albeit
> in the chapter about trigraphs.)

Oops, indeed, it's mentioned in the ANSI C++ standard [lex.digraph]. (Note to 
myself: First look, then keep silent ;-) )

I still opt for not using replacement sequences.
 
> C adds it in C99 for increased compability with Standard C++.
> I changed that to the version used everywhere else:
> if( state & Qt:ShiftButton )
>  newTabInFront = !newTabInFront;

Thanks.
>
> I also removed the KonqMainWindow::setCurrentView() function from the
> patch, which I don't need anymore.
>
> > Now that we have David's OK and coolo's blessing, your fixed patch should
> > go in soon.
>
> Well, I've reviewed my code today, and I'm reasonable sure that it won't
> break anything, so yes I would like to see this included.

Then: Please commit :-)
>
> > Hmm, don't consistency fixes count towards bugs, and not towards wishes?
>
> On the topic of consistency, one thing, which I already mentioned in a
> earlier mail: The history isn't copied for new tabs/windows openend from
> the Up/Home actions. 

Hmm, I haven't noticed this, but it should copy the history. If one goes 'Up' 
with LMB, the history will be filled. So supporting MMB or Ctrl+LMB makes one 
naively expect that the history will be available, too, even if a new view 
has been created. But your way of contemplating the issues isn't wrong, 
either. Let's leave it as is for now, it can be fixed later anyway.

> This mirrows the behaviour for opening new Tabs/new 
> Windows from links. The back/forward are inconsistent in that they copy the
> history into the new view. I think this is a feature.

So do I. I'd even go as far stating that people *expect* the history to be 
copied -> no actual inconsistency.
>
[...]

mfg
 Leo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050116/4ae566b1/attachment.sig>