make image loading indicator on by default

[Helge Deller]

On Friday 07 January 2005 22:02, Martin Koller wrote:
> On Friday 07 January 2005 18:27, Enrico Ros wrote:
> > > Aside from it looks butt ugly with the placeholder icon, no.
> >
> > Isn't there another placeholder icon available ? Even not showing the icon
> > is a great option imho!
> 
> This is a matter of taste. I do like the frame and as the icon is also grey in 
> grey, it does not disturb the eye.
> I like it (and I can tell you it's also helpful when you have DSL)

Ok, so some like it and some does not.
My proposal is to commit the attached patch in CVS to enable image loading indicator by default.
Then we will get more user-feedback (which we probably don't get right now when it's off by default) and can decide before the final release of 3.4....
Ok ? 

Helge

PS: No answer will mean OK for me and I will commit tomorrow.

-------------- next part --------------
Index: kdelibs/khtml/khtml_settings.cc
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtml_settings.cc,v
retrieving revision 1.108
diff -u -p -r1.108 khtml_settings.cc
--- kdelibs/khtml/khtml_settings.cc	22 Dec 2004 21:19:27 -0000	1.108
+++ kdelibs/khtml/khtml_settings.cc	8 Jan 2005 20:39:44 -0000
@@ -357,7 +357,7 @@ void KHTMLSettings::init( KConfig * conf
       d->m_bAutoLoadImages = config->readBoolEntry( "AutoLoadImages", true );
 
     if ( reset || config->hasKey( "UnfinishedImageFrame" ) )
-      d->m_bUnfinishedImageFrame = config->readBoolEntry( "UnfinishedImageFrame", false );
+      d->m_bUnfinishedImageFrame = config->readBoolEntry( "UnfinishedImageFrame", true );
 
     if ( reset || config->hasKey( "ShowAnimations" ) )
     {
Index: kdebase/kcontrol/konqhtml/htmlopts.cpp
===================================================================
RCS file: /home/kde/kdebase/kcontrol/konqhtml/htmlopts.cpp,v
retrieving revision 1.88
diff -u -p -r1.88 htmlopts.cpp
--- kdebase/kcontrol/konqhtml/htmlopts.cpp	22 Dec 2004 21:19:28 -0000	1.88
+++ kdebase/kcontrol/konqhtml/htmlopts.cpp	8 Jan 2005 20:39:44 -0000
@@ -220,7 +220,7 @@ void KMiscHTMLOptions::load()
     bool underlineLinks = READ_BOOL("UnderlineLinks", DEFAULT_UNDERLINELINKS);
     bool hoverLinks = READ_BOOL("HoverLinks", true);
     bool bAutoLoadImages = READ_BOOL( "AutoLoadImages", true );
-    bool bUnfinishedImageFrame = READ_BOOL( "UnfinishedImageFrame", false );
+    bool bUnfinishedImageFrame = READ_BOOL( "UnfinishedImageFrame", true );
     QString strAnimations = READ_ENTRY( "ShowAnimations" ).lower();
 
     bool bAutoRedirect = m_pConfig->readBoolEntry( "AutoDelayedActions", true );