[PATCH] Konqueror adblock v3

[Ivor Hewitt]

On Thursday 28 Apr 2005 21:29, David Faure wrote:
> On Thursday 28 April 2005 21:51, Ivor Hewitt wrote:
> > Version 3....
>
> What's the new CachedImage constructor for? (in kdelibs.diff)
> I think it can be removed again.
>
Ooops that was part of my transparent placeholder experiment.

> +      "kde-filter.desktop" <<
> should be kde-khtml_filter.desktop for consistency, no?
>
will do.

>         QString s = "Filter";
>         QString key;
>         QTextOStream( &key ) << s << "-" << i;
> Can be written a much simpler way:
>        QString key = "Filter-" + QString::number(i);
>
thanks.

> The rest looks good to me.

Thanks for the feedback. 

-- 
Ivor Hewitt.
http://www.ivor.it - tech | http://www.ivor.org - hedge