[PATCH] Konqueror adblock v3

[David Faure]

On Thursday 28 April 2005 21:51, Ivor Hewitt wrote:
> Version 3....

What's the new CachedImage constructor for? (in kdelibs.diff)
I think it can be removed again.

+      "kde-filter.desktop" <<
should be kde-khtml_filter.desktop for consistency, no?

        QString s = "Filter";
        QString key;
        QTextOStream( &key ) << s << "-" << i;
Can be written a much simpler way: 
       QString key = "Filter-" + QString::number(i);

The rest looks good to me.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).