[PATCH] Automatic assignment of accesskeys

[Robert Ewald]

On Monday 11 April 2005 11:30, Lubos Lunak wrote:
> On Monday 11 of April 2005 00:29, Robert Ewald wrote:
> > On Friday 08 April 2005 15:09, Lubos Lunak wrote:

[ snip ]

>  We already have that: Just press / or ' and start typing. That doesn't
> work with some elements like buttons, but that's exactly why my patch gives
> those higher priority.

I agree. Please consider however, that it does not work yet with nonlatin 
languages like Japanese. In my proposal, the language is no problem at all.
Another problem is, that you have to hit different keys ( STRG or ' ) 
depending on whether to go to an image link or a text link. I think that is 
suboptimal...

[ snip ]

>  I consider that to be a problem of the type ahead find implementation. It
> should first search visible elements, like it does e.g. in Mozilla. Since
> after the Find Previous fixes now I'm almost an expert on KHTML's find
> implementation ;) , I hope I'll be able to do something with this soon.
>  And having too many accesskeys looks really weird with pages with many
> links, e.g. http://seznam.cz looked awfully when I had higher limit in my

A clever layouting method would be necessary. This is indeed a nontrivial 
problem. For a start the tooltip would have to be scaled in order not to be 
bigger than the underlying element. There would be many many tooltips on 
pages like http://seznam.cz, but well, you don't have to look at it all the 
time, just for navigation :-)

> patch. Not to mention that'd need revamping the accesskeys implementation
> because it now supports only one key, not a sequence of them.

I have implemented the key sequence. I attach the file for reference. Sorry 
for the bloat, but at the moment I can't diff.

Thanks

Robert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtmlview.h
Type: text/x-chdr
Size: 19302 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050412/b259631f/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtmlview.cpp
Type: text/x-csrc
Size: 127100 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050412/b259631f/attachment.c>