[patch] fix for window.open(url, frame)

[David Faure]

On Saturday 04 September 2004 12:44, Koos Vriezen wrote:
> Hi,
> 
> As shown in the tread 'replacing the textarea widget', the frame access
> changes broke window.open(url,frame). Tried it with the 3.3 branch, same
> result (likely 3.2 is affected as well).
> The problem is that KHTMLPart::findFrameParent is called with a null
> callingPart. This is done from KonqMainWindow::slotCreateNewWindow. The
> patch is to get the callingPart back from the sender() call. See patch.
OK.

> Though the comments are a bit confusing and might point to somewhere else
> to solve. At KonqMainWindow::slotCreateNewWindow it says that
>  // Found a view. If url isn't empty, we should open it - but this never
>  // happens currently
The comment means: the URL given to createNewWindow is empty.
Check what kjs_window.cpp does: the first arg of createNewWindow() is KURL().
The opening of the URL is done later on, once we have our new view.

> and at KJS::Window::openWindow it states:
>  // request window (new or existing if framename is set)
Right.

> but acts only like the new part is a new window.
? I don't see that?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).