initialized value.

Olivier Goffart ogoffart at tiscalinet.be
Thu Sep 2 21:16:49 BST 2004


Hi, 
While running Kopete under valgrind, i got that message:

==16835==
==16835== Conditional jump or move depends on uninitialised value(s)
==16835==    at 0x1BC53693: KHTMLPart::clear() (khtml_part.cpp:1180)
==16835==    by 0x1BC56714: KHTMLPart::begin(KURL const&, int, int) 
(khtml_part.cpp:1649)
==16835==    by 0x1EBB956E: AppearanceConfig::slotUpdatePreview() 
(appearanceconfig.cpp:640)
==16835==    by 0x1EBB842E: AppearanceConfig::slotStyleSelected() 
(appearanceconfig.cpp:472)
==16835==    by 0x1EBBA9BB: AppearanceConfig::qt_invoke(int, QUObject*) 
(appearanceconfig.moc:135)


It seems to me that   d->m_bCleared   is not initialised.

I imagine it shouldn't be difficult to fix that. 
I send you a possible patch which fix it. I decided to initialize the value to 
false. But i absolutely don't know if it is the correct choice.

(the patch is against the KDE_3_3_BRANCH)

Should i commit that to head ? and on the branch ?  or let you handle the 
problem ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml.diff
Type: text/x-diff
Size: 633 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040902/964ff104/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040902/964ff104/attachment.sig>


More information about the kfm-devel mailing list